Re: [PATCH v2 1/1] t1403: verify that path exists and is a file
From: Patrick Steinhardt <hidden>
Date: 2025-03-04 11:03:01
On Tue, Mar 04, 2025 at 02:57:22PM +0530, Mahendra Dani wrote:
quoted hunk ↗ jump to hunk
test -e does not provide a nice error message when we hit test failures, so use test_path_exists() instead and verify that if the path exists then it is a file using test_path_is_file(). Signed-off-by: Mahendra Dani <redacted> --- t/t1403-show-ref.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/t/t1403-show-ref.sh b/t/t1403-show-ref.sh index 9d698b3cc3..4afde01a29 100755 --- a/t/t1403-show-ref.sh +++ b/t/t1403-show-ref.sh@@ -196,7 +196,8 @@ test_expect_success 'show-ref --verify with dangling ref' ' remove_object() { file=$(sha1_file "$*") && - test -e "$file" && + test_path_exists "$file" && + test_path_is_file "$file" && rm -f "$file" } &&
There is no need to execute both functions. The underlying implementation of these functions use `test -e` and `test -f`, respectively. The former merely checks whether a path exists, whereas the latter verifies that the path is a file. It follows that when the path is a file it also has to exist, so using `test -e` (or rather its wrapper function `test_path_exists`) is redundant. Patrick