Re: [RFC PATCH] config: teach `repo_config()` to allow `repo` to be NULL
From: Eric Sunshine <hidden>
Date: 2025-02-27 18:35:22
From: Eric Sunshine <hidden>
Date: 2025-02-27 18:35:22
On Thu, Feb 27, 2025 at 12:55 PM Usman Akinyemi [off-list ref] wrote:
The `repo` value can be NULL if a builtin command is run outside any repository. The current implementation of `repo_config()` will fail if `repo` is NULL. If the `repo` is NULL the `repo_config()` can ignore the repository configuration but it should read the other configuration sources like the system-side configuration instead of failing.
s/side/wide/
Teach the `repo_config()` to allow `repo` to be NULL by calling the `read_very_early_config()` which read config but only enumerate system and global settings. Suggested-by: Junio C Hamano <redacted> Mentored-by: Christian Couder [off-list ref] Signed-off-by: Usman Akinyemi <redacted>