Thread (3 messages) 3 messages, 3 authors, 2025-02-25

Re: [PATCH v3 0/2] Fix Meson Perl version check

From: Patrick Steinhardt <hidden>
Date: 2025-02-19 07:18:07

On Tue, Feb 18, 2025 at 11:12:03AM -0800, Junio C Hamano wrote:
Peter Oliver [off-list ref] writes:
quoted
Suggested comments added.

Peter Oliver (2):
  meson: bump minimum required Perl version to 5.26.0
  meson: fix Perl version check for Meson versions before 1.7.0

 meson.build | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
I wasn't involved in the review of the previous rounds (so it was a
bit of surprise for me to be listed on the To: line), but it seems
that Patrick and you polished these two together, so I'll see if I
can add Patrick's acked-by/reviewed-by while queuing by waiting for
the earth to turn one rotation.
Yup, this version looks good to me, thanks Peter. So please feel free to
add either my Acked-by or Reviewed-by, I'd be fine with either.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help