Peter Oliver [off-list ref] writes:
Suggested comments added.
Peter Oliver (2):
meson: bump minimum required Perl version to 5.26.0
meson: fix Perl version check for Meson versions before 1.7.0
meson.build | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
I wasn't involved in the review of the previous rounds (so it was a
bit of surprise for me to be listed on the To: line), but it seems
that Patrick and you polished these two together, so I'll see if I
can add Patrick's acked-by/reviewed-by while queuing by waiting for
the earth to turn one rotation.
Thanks.
On Tue, Feb 18, 2025 at 11:12:03AM -0800, Junio C Hamano wrote:
Peter Oliver [off-list ref] writes:
quoted
Suggested comments added.
Peter Oliver (2):
meson: bump minimum required Perl version to 5.26.0
meson: fix Perl version check for Meson versions before 1.7.0
meson.build | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
I wasn't involved in the review of the previous rounds (so it was a
bit of surprise for me to be listed on the To: line), but it seems
that Patrick and you polished these two together, so I'll see if I
can add Patrick's acked-by/reviewed-by while queuing by waiting for
the earth to turn one rotation.
Yup, this version looks good to me, thanks Peter. So please feel free to
add either my Acked-by or Reviewed-by, I'd be fine with either.
Patrick
On Tue, 18 Feb 2025, Junio C Hamano wrote:
I wasn't involved in the review of the previous rounds (so it was a
bit of surprise for me to be listed on the To: line)
Apologies if that wasn’t the correct process. I am not a regular contributor, and was trying to follow the process described at https://git-scm.com/docs/SubmittingPatches#_choosing_your_reviewers, “After the list reached a consensus…”.
--
Peter Oliver