Re: [PATCH 1/7] builtin/verify-tag: stop using `the_repository`
From: Patrick Steinhardt <hidden>
Date: 2025-02-17 06:55:51
On Sat, Feb 15, 2025 at 04:27:17AM +0530, Usman Akinyemi wrote:
quoted hunk ↗ jump to hunk
@@ -35,7 +34,8 @@ int cmd_verify_tag(int argc, OPT_END() }; - git_config(git_default_config, NULL); + if (repo) + repo_config(repo, git_default_config, NULL);
I recently noticed that we have `usage_with_options_if_asked()`. Should we use that function rather than making the call to `git_config()` conditional? Otherwise it's not obvious why we have the conditional in the first place. The same comment also applies to subsequent commits. Patrick