Thread (1 message) 1 message, 1 author, 2025-02-06

Re: [PATCH v7 7/7] builtin/clone: teach git-clone(1) the --revision= option

From: Junio C Hamano <hidden>
Date: 2025-02-06 20:26:17

Patrick Steinhardt [off-list ref] writes:
On Thu, Feb 06, 2025 at 07:33:35AM +0100, Toon Claes wrote:
quoted
diff --git a/t/t5621-clone-revision.sh b/t/t5621-clone-revision.sh
new file mode 100755
index 0000000000000000000000000000000000000000..d4889a954e6300e0e327ebe7dfcf73569d966829
--- /dev/null
+++ b/t/t5621-clone-revision.sh
@@ -0,0 +1,123 @@
+#!/bin/sh
+
+test_description='tests for git clone --revision'
+GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
+export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
+
+TEST_PASSES_SANITIZE_LEAK=true
One last nit: this line is not needed anymore, as tests are required to
pass with the leak sanitizer by default now. Other than that this series
looks good to me, and this change alone does not warrant a reroll from
my point of view.

Thanks!
I'll touch it up while queuing, and mark the topic for 'next', then.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help