Re: [GSoC][PATCH] remote: relocate valid_remote_name

On Tue, 4 Feb 2025 at 13:25, Patrick Steinhardt [off-list ref] wrote:

Nit: you don't only move the function declaration from "refspec.h" to
"remote.h", but also move its definition from "refspec.c" to "remote.c".
So you might want to instead say that you move the function between
subsystems, which would imply both moves.

Makes sense. Thanks for pointing it out.

The change itself looks straight-forward to me. Did you happen to check
whether this allows you to drop any includes for "refspec.h"?

I think you mean refspec.c, as refspec.h doesn’t have includes.
Yeah, I did check -- no include drop found in refspec.c.

Thanks
Meet