Re: [PATCH v2 1/6] version: refactor redact_non_printables()

Christian Couder [off-list ref] writes:

On Mon, Jan 20, 2025 at 6:10 PM Usman Akinyemi
[off-list ref] wrote:

quoted

On Fri, Jan 17, 2025 at 11:56 PM Junio C Hamano [off-list ref] wrote:

quoted

Usman Akinyemi [off-list ref] writes:

quoted

quoted

quoted

+static void redact_non_printables(struct strbuf *buf)
+{
+     strbuf_trim(buf);
+     for (size_t i = 0; i < buf->len; i++) {
+             if (buf->buf[i] <= 32 || buf->buf[i] >= 127)

<sane-ctype.h> defines isprint() we can use here.

I think it would be better to add this in another commit so that one commit
does one thing. I will add it after this patch series got settled,
what do you think ?

Alternatively it could be done in its own preparatory patch at the
beginning of this patch series.

Yup, a preliminary clean-up sounds fine, but so does a follow-up
after all the dust settles.

Thanks.