Thread (27 messages) 27 messages, 4 authors, 2025-01-24

Re: [PATCH v2 5/5] pack-write: pass hash_algo to internal functions

From: Karthik Nayak <hidden>
Date: 2025-01-17 09:55:15

Patrick Steinhardt [off-list ref] writes:
On Fri, Jan 17, 2025 at 10:20:52AM +0100, Karthik Nayak wrote:
quoted
The internal functions `write_rev_trailer()`, `write_rev_trailer()`,
`write_mtimes_header()` and write_mtimes_trailer()` use the global
`the_hash_algo` variable to access the repository's hash function. Pass
the hash from down as we've added made them available in the previous
This doesn't read quite right -- from where do we want to pass it down?
Other than that the series looks good to me, thanks!
I should have s/from//, but let me rephrase it to make it clearer.

Thanks for the review.
Patrick

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help