Thread (1 message) 1 message, 1 author, 2025-01-16

Re: [PATCH v3 6/6] builtin: send usage() help text to standard output

From: Junio C Hamano <hidden>
Date: 2025-01-16 20:37:40

Junio C Hamano [off-list ref] writes:
The above is a bit of a lie.  There is one strange thing I did,
which needs to be redone.
quoted
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index bed2816c2d..9bd4b29c5b 100644
--- a/builtin/fetch-pack.c
+++ b/builtin/fetch-pack.c
@@ -176,6 +176,9 @@ int cmd_fetch_pack(int argc,
 			list_objects_filter_set_no_filter(&args.filter_options);
 			continue;
 		}
+
+		if (!strcmp(arg, "-h"))
+			show_usage_and_exit_if_asked(2, &arg - 1, fetch_pack_usage);
 		usage(fetch_pack_usage);
 	}
 	if (deepen_not.nr)
I think we should just call show_usage_and_exit_if_asked() before
entering the loop without changing anything else.
I have worked on a reroll and moved this piece to the "oddball"
pile.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help