Re: [PATCH] instaweb: fix ip binding for the python http.server
From: Junio C Hamano <hidden>
Date: 2025-01-10 23:32:54
Alecs King [off-list ref] writes:
`git instaweb -d python` should bind the server to 0.0.0.0 `git instaweb -d python -l` should bind the server to 127.0.0.1
That is a correct statement of the fact. What makes this patch worthwhile is that the current code gets it the other way around since its inception at 2eb14bb2 (git-instaweb: add Python builtin http.server support, 2019-01-28). Well spotted. There seem to be some backends that simply ignore the "--local" option. Should they be somehow "fixed" (or at least making it a documented bug)? It is not within the scope of this patch, but since the script has our attention... Thanks, will queue.
quoted hunk
Signed-off-by: Alecs King <redacted> --- git-instaweb.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/git-instaweb.sh b/git-instaweb.sh index 5ad50160bb..7b44f70789 100755 --- a/git-instaweb.sh +++ b/git-instaweb.sh@@ -694,9 +694,9 @@ class GitWebRequestHandler(CGIHTTPRequestHandler): return result -bind = "127.0.0.1" +bind = "0.0.0.0" if "$local" == "true": - bind = "0.0.0.0" + bind = "127.0.0.1" # Set our http root directory # This is a work around for a missing directory argument in older Python versions