Thread (31 messages) 31 messages, 3 authors, 2025-01-03

Re: [PATCH v2 11/12] t/Makefile: make "check-meson" work with Dash

From: Jonathan Nieder <hidden>
Date: 2025-01-02 15:37:52

Hi,

Patrick Steinhardt wrote:
The "check-meson" target uses process substitution to check whether
extracted contents from "meson.build" match expected contents. Process
substitution is unportable though and thus the target will fail when
using for example Dash.

Fix this by writing data into a temporary directory.

Signed-off-by: Patrick Steinhardt <redacted>
---
 t/.gitignore |  1 +
 t/Makefile   | 12 +++++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)
Without this, I get the error described in
https://lore.kernel.org/git/CAHWeT-boK3x6mup11boEinNDQiAxxf0vwvZkxsGRc_GRvXYA8g@mail.gmail.com/ (local)
('/bin/sh: 10: Syntax error: "(" unexpected'), and with this, the
build in the Debian buildd environment succeeds.

Tested-by: Jonathan Nieder <redacted>

Thanks for fixing it.

Sincerely,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help