Thread (37 messages) 37 messages, 3 authors, 2024-12-28

Re: [PATCH v2 0/5] GIT-VERSION-GEN: fix overriding values

From: Jeff King <hidden>
Date: 2024-12-20 15:56:12

On Fri, Dec 20, 2024 at 01:22:44PM +0100, Patrick Steinhardt wrote:
Changes in v2:

  - Don't strip leading `v`s when `GIT_VERSION` was set explicitly.
  - Allow setting build info via "config.mak" again.
  - Wire up build info options for Meson.
  - Link to v1: https://lore.kernel.org/r/20241219-b4-pks-git-version-via-environment-v1-0-9393af058240@pks.im (local)
Thanks, I confirmed that this fixes the doc-diff issue, and setting
values in config.mak works.

I left some small comments on patch 1. Patches 2-4 look good to me, and
I'm not qualified to comment on meson patches. ;)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help