Thread (52 messages) 52 messages, 2 authors, 2024-12-02

Re: [PATCH v4 6/8] worktree: add relative cli/config options to `move` command

From: Caleb White <hidden>
Date: 2024-11-23 04:11:15

On Fri Nov 22, 2024 at 9:55 AM CST, Phillip Wood wrote:
On 01/11/2024 04:38, Caleb White wrote:
quoted
[...]
+test_expect_success 'move worktree with absolute path to relative path' '
+	git config worktree.useRelativePaths false &&
+	git worktree add ./absolute &&
+	git worktree move --relative-paths absolute relative &&
+	cat relative/.git >actual &&
+	echo "gitdir: ../.git/worktrees/absolute" >expect &&
+	test_cmp expect actual &&
+	git config worktree.useRelativePaths true &&
+	git worktree move relative relative2 &&
+	cat relative2/.git >actual &&
+	echo "gitdir: ../.git/worktrees/absolute" >expect &&
+	test_cmp expect actual
+'
As with the last patch we should use test_config and stop copying files
just to compare them. It's probably worth checking the gitdir file as
well as .git here as well.
Updated, thanks for pointing that out.

Best,

Caleb
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help