Re: [PATCH v2 2/2] fetch-pack: warn if in commit graph but not obj db
From: Taylor Blau <hidden>
Date: 2024-11-01 15:18:18
On Thu, Oct 31, 2024 at 02:19:01PM -0700, Jonathan Tan wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t5330-no-lazy-fetch-with-commit-graph.sh b/t/t5330-no-lazy-fetch-with-commit-graph.sh index 5eb28f0512..feccd58324 100755 --- a/t/t5330-no-lazy-fetch-with-commit-graph.sh +++ b/t/t5330-no-lazy-fetch-with-commit-graph.sh@@ -39,7 +39,7 @@ test_expect_success 'fetch any commit from promisor with the usage of the commit test_commit -C with-commit any-commit && anycommit=$(git -C with-commit rev-parse HEAD) && GIT_TRACE="$(pwd)/trace.txt" \ - git -C with-commit-graph fetch origin $anycommit 2>err && + test_must_fail git -C with-commit-graph fetch origin $anycommit 2>err &&
It appears that this line breaks CI:
https://github.com/ttaylorr/git/actions/runs/11631453312/job/32392591229
because you're using a one-shot environment variable assignment before
calling a shell function.
This should instead be:
test_must_fail env GIT_TRACE="$(pwd)/trace.txt" \
git -C with-commit-graph fetch origin $anycommit 2>err &&
Thanks,
Taylor