Thread (6 messages) 6 messages, 6 authors, 2024-10-29

Re: Inconsistent handling of corrupt patches based on line endings

From: Taylor Blau <hidden>
Date: 2024-10-28 18:11:17

On Mon, Oct 28, 2024 at 05:57:54PM +0100, Peregi Tamás wrote:
Hi all,

I might've found an inconsistency in how git-apply treats corrupt patches
(representing empty context lines with completely empty lines instead of
lines containing a single space - usually a result of a "trim trailing
whitespace" editor setting) based on whether the patch file uses
Windows-style line endings (CRLF) or Unix-style line endings (LF only).
Let's see if any recent apply.c folks have thoughts...:

$ git shortlog -nse --no-merges --since=3.years.ago.. -- apply.c
    21  Elijah Newren [off-list ref]
    12  Patrick Steinhardt [off-list ref]
     7  Ævar Arnfjörð Bjarmason [off-list ref]
     5  Junio C Hamano [off-list ref]
     4  Jeff King [off-list ref]
     4  René Scharfe [off-list ref]

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help