Thread (3 messages) 3 messages, 2 authors, 2024-10-22

Re: [PATCH] doc: consolidate extensions in git-config documentation

From: Taylor Blau <hidden>
Date: 2024-10-22 17:13:13

On Tue, Oct 22, 2024 at 12:08:49AM +0000, Caleb White wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/config/extensions.txt b/Documentation/config/extensions.txt
index f0a784447db09856639ec43b443681f13c17c966..5dc569d1c9c77c15e32441493289f9c9dd5e7f0b 100644
--- a/Documentation/config/extensions.txt
+++ b/Documentation/config/extensions.txt
@@ -1,17 +1,13 @@
-extensions.objectFormat::
-	Specify the hash algorithm to use.  The acceptable values are `sha1` and
-	`sha256`.  If not specified, `sha1` is assumed.  It is an error to specify
-	this key unless `core.repositoryFormatVersion` is 1.
+extensions.*::
+	Unless otherwise stated, is an error to specify an extension if
+	`core.repositoryFormatVersion` is not `1`. See
+	linkgit:gitrepository-layout[5].
 +
-Note that this setting should only be set by linkgit:git-init[1] or
-linkgit:git-clone[1].  Trying to change it after initialization will not
-work and will produce hard-to-diagnose issues.
-
-extensions.compatObjectFormat::
-
+--
+compatObjectFormat::
Should this be `extensions.compatObjectFormat` instead of
`compatObjectFormat`? I think the latter will produce awkward headings
when these all get merged into git-config(1).

Otherwise, looking good. Thanks for working on this!

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help