Thread (175 messages) 175 messages, 5 authors, 2024-12-03

Re: [PATCH 02/20] packfile: pass down repository to `unuse_one_window`

From: Taylor Blau <hidden>
Date: 2024-10-21 21:08:26

On Mon, Oct 21, 2024 at 11:57:45AM +0200, Karthik Nayak wrote:
The function `unuse_one_window` currently relies on the global variable
`the_repository`. To eliminate global variable usage in `packfile.c`, we
should progressively shift the dependency on the_repository to higher
layers. Let's remove its usage from this function and any related ones.

Signed-off-by: Karthik Nayak <redacted>
---
 builtin/pack-objects.c | 12 ++++++------
 pack-check.c           |  6 +++---
 packfile.c             | 25 +++++++++++++------------
 packfile.h             |  3 ++-
 streaming.c            |  2 +-
 5 files changed, 25 insertions(+), 23 deletions(-)
All looks correct, as unuse_one_window() already uses the_repository, so
I don't think any behavior is changed here...

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help