Re: [PATCH] Fix duplicate word typos
From: Taylor Blau <hidden>
Date: 2024-10-21 20:04:31
On Mon, Oct 21, 2024 at 11:57:25AM +0200, Kristoffer Haugsbakk wrote:
On Mon, Oct 21, 2024, at 11:47, Patrick Steinhardt wrote:quoted
On Sat, Oct 19, 2024 at 12:06:54PM +0200, Kristoffer Haugsbakk wrote:quoted
Hi I guess it was an intentional choice to not use an “area” in the commit message? I found this similar patch which used `*` as the area: abcb66c614c (*: fix typos which duplicate a word, 2021-06-11); review here: https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/ (local)I think many projects also use the "global:" prefix to denote changes all over the place. We also do this in Git, even though I should probably say that all patches that do have that prefix are from myself :P In any case, I don't have a strong opinion here. PatrickI forgot to mention that “treewide” is used to a decent degree. :)
Yes, I think in any case we can blame Patrick for setting the convention here ;-). (For what it's worth, I have occasionally used '*:' in the past, but I don't think it matters so long as we use something to avoid 99.9% of commits being prefixed with an area and having a few odd ones stuck out). Thanks, Taylor