On Mon, Oct 21, 2024 at 03:03:09PM -0400, Jeff King wrote:

On Mon, Oct 21, 2024 at 07:55:06AM +0200, Piotr Szlazak wrote:

quoted

On the second look code changes will be needed, as at the moment final
result will differ between:
[uploadpack]
        allowTipSHA1InWant = true
        allowReachableSHA1InWant = true
        allowAnySHAInWant = false

and:

[uploadpack]
        allowAnySHAInWant = false
        allowTipSHA1InWant = true
        allowReachableSHA1InWant = true

I'd expect them to differ. The config is read in order with a "last one
wins" rule. The thing that the documentation should be making clear is
that the three overlap in what they are affecting, and so "last one" is
not just a single key, but these three inter-related keys.

Agreed. I think the "last one wins" policy is well understood throughout
Git's rules for how configuration layers are parsed, and not worth
repeating purely for the purposes of this specific piece of the
documentation.

Thanks,
Taylor