Re: [PATCH v3 3/3] clang-format: don't align expressions after linebreaks
From: Kyle Lippincott <hidden>
Date: 2024-10-14 21:23:34
On Fri, Oct 11, 2024 at 6:50 PM Karthik Nayak [off-list ref] wrote:
We enforce alignment of expressions after linebreaks. Which means for
code such as
return a || b;
it will expect:
return a ||
b;
we instead want 'b' to be indent with tabs, which is already done by the
'ContinuationIndentWidth' variable.
Why do we want `b` to be indented by 8 columns instead of aligned? I
think this is harder to read:
int some_int_variable = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;
Of course, this is even better, if it fits in 80 cols:
int some_int_variable =
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;
quoted hunk ↗ jump to hunk
So let's explicitly set 'AlignOperands' to false. Signed-off-by: Karthik Nayak <redacted> --- .clang-format | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)diff --git a/.clang-format b/.clang-format index 9547fe1b77..b48e7813e4 100644 --- a/.clang-format +++ b/.clang-format@@ -42,10 +42,9 @@ AlignConsecutiveMacros: true # int cccccccc; AlignEscapedNewlines: Left -# Align operands of binary and ternary expressions -# int aaa = bbbbbbbbbbb + -# cccccc; -AlignOperands: true +# Don't enforce alignment after linebreaks and instead +# rely on the ContinuationIndentWidth value. +AlignOperands: false # Don't align trailing comments # int a; // Comment a --2.47.0