On 2024.10.11 11:13, Oswald Buddenhagen wrote:

just some nits:

On Thu, Oct 10, 2024 at 02:11:53PM -0700, Josh Steadmon wrote:

quoted

+++ b/ci/run-build-and-minimal-fuzzers.sh
+fuzzers="
+commit-graph \
+config \
+credential-from-url-gently \
+date \
+pack-headers \
+pack-idx \
+"

the trailing space-backslashes can be left out, which would make the
code less noisy. then the variable would contain linebreaks instead of
spaces, which the for loop would be just fine with (as $IFS contains
LF).

Fixed in V2.

quoted

+for fuzzer in $fuzzers ; do

the space before the semicolon seems excessive.

Fixed in V2.

quoted

+++ b/oss-fuzz/fuzz-credential-from-url-gently.c
+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
+

are these seemingly redundant prototypes meant to suppress compiler
warnings?

Yes, unfortunately we get complaints without them.

quoted

+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
+{

Thanks for the review!