Thread (126 messages) 126 messages, 9 authors, 2024-12-05

Re: [PATCH v6 3/6] set-head: better output for --auto

From: Bence Ferdinandy <hidden>
Date: 2024-10-12 22:29:52

Possibly related (same subject, not in this thread)

On Fri Oct 11, 2024 at 22:43, karthik nayak [off-list ref] wrote:
"Bence Ferdinandy" [off-list ref] writes:

[snip]
quoted
quoted
quoted
+		git remote set-head --auto origin >output &&
+		echo "'\''origin/HEAD'\'' is now created and points to '\''main'\''" >expect &&
Nit: might be cleaner to use `${SQ}` here and below
You mean something like this?

	git remote set-head --auto origin >output &&
	HEAD="'\''origin/HEAD'\''" &&
	echo "${HEAD} is now created and points to '\''main'\''" >expect &&

I tried a few variations and this is what I could get working, but I may be
simply missing something with the backtick.
I mean simply this

    git remote set-head --auto origin >output &&
    echo "${SQ}origin/HEAD${SQ} is now created and points to
${SQ}main${SQ}" >expect &&
Ah, I see in other tests this is used, but not in this particular test file.
It's a bit hard to decide which is more cryptic, but ${SQ} is nicer on the
eyes. On the other hand I would either switch the entire file in a separate
patch or leave in the '\'' here as well. Or I guess one could go through the
entire test base and switch everything to either one or the other for
consistency.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help