Thread (22 messages) 22 messages, 6 authors, 2024-10-22

Re: [PATCH v2 1/2] blame: respect .git-blame-ignore-revs automatically

From: Eric Sunshine <hidden>
Date: 2024-10-12 06:43:24

On Sat, Oct 12, 2024 at 2:07 AM Eric Sunshine [off-list ref] wrote:
On Sat, Oct 12, 2024 at 12:38 AM Abhijeetsingh Meena via GitGitGadget
[off-list ref] wrote:
quoted
+       /*
+       * By default, add .git-blame-ignore-revs to the list of files
+       * containing revisions to ignore if it exists.
+       */
+       if (access(".git-blame-ignore-revs", F_OK) == 0) {
+               string_list_append(&ignore_revs_file_list, ".git-blame-ignore-revs");
+       }
A couple style nits and a couple questions...
One other observation: The comment above this code block doesn't say
anything that isn't already stated just as clearly by the code itself.
Hence, the comment adds no value, thus should be dropped.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help