Re: [PATCH 0/2] alternate approach to fixing fsmonitor hangs

Jeff King [off-list ref] writes:

On Wed, Oct 09, 2024 at 01:03:14AM +0900, Koji Nakamaru wrote:

quoted

quoted

But I've cleaned it up for presentation here, so at least we can look at
the final form of both and see which we prefer.

Thank you for the new patch. It prevents to start accepting requests
until starting fs event listening and simplifies the code flow. It also
has sufficient comments, so later everyone can easily understand how it
works. I also tested it both on mac and windows and it works correctly.

I think this one should be adopted :)

Thanks for reviewing, and for all your work identifying the problem in
the first place! Looks like Junio has picked up my patch and it's
already in 'next', so hopefully these 6-hour CI timeouts will soon be a
thing of the past. :)

Yup.  Thanks, both of you.