[PATCH 18/21] t/helper: fix leaking buffer in "dump-untracked-cache"
From: Patrick Steinhardt <hidden>
Date: 2024-10-11 05:33:08
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Patrick Steinhardt <hidden>
Date: 2024-10-11 05:33:08
Subsystem:
the rest · Maintainer:
Linus Torvalds
We never release the local `struct strbuf base` buffer, thus leaking memory. Fix this leak. This leak is exposed by t7063, but plugging it alone does not make the whole test suite pass. Signed-off-by: Patrick Steinhardt <redacted> --- t/helper/test-dump-untracked-cache.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/t/helper/test-dump-untracked-cache.c b/t/helper/test-dump-untracked-cache.c
index 4f010d53249..b2e70837a90 100644
--- a/t/helper/test-dump-untracked-cache.c
+++ b/t/helper/test-dump-untracked-cache.c@@ -68,5 +68,7 @@ int cmd__dump_untracked_cache(int ac UNUSED, const char **av UNUSED) printf("flags %08x\n", uc->dir_flags); if (uc->root) dump(uc->root, &base); + + strbuf_release(&base); return 0; }
--
2.47.0.dirty