Thread (150 messages) 150 messages, 4 authors, 2024-11-20

Re: [PATCH v5 1/9] ref: initialize "fsck_ref_report" with zero

From: Karthik Nayak <hidden>
Date: 2024-10-08 07:29:56

shejialuo [off-list ref] writes:
In "fsck.c::fsck_refs_error_function", we need to tell whether "oid" and
"referent" is NULL. So, we need to always initialize these parameters to
NULL instead of letting them point to anywhere when creating a new
"fsck_ref_report" structure.

The original code explicitly initializes the "path" member in the
"struct fsck_ref_report" to NULL (which implicitly 0-initializes other
members in the struct). It is more customary to use "{ 0 }" to express
that we are 0-initializing everything. In order to align with the the
s/the//

[snip]

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help