Re: [PATCH] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o
flat view
From: Junio C Hamano <hidden>
Date: 2024-10-08 00:53:44
"Philippe Blain via GitGitGadget" [off-list ref] writes:
From: Philippe Blain <redacted>
The clar source file '$(UNIT_TEST_DIR)/clar/clar.c' includes the
generated 'clar.suite', but this dependency is not taken into account by
our Makefile, so that it is possible for a parallel build to fail if
Make tries to build 'clar.o' before 'clar.suite' is generated.
Correctly specify the dependency.
Signed-off-by: Philippe Blain <redacted>
---
Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o
Hi Patrick,
I tried building v2.47.0 and stumbled onto this small issue. It
reproduces for me from a fresh clone on my old 2009 Mac with make -j -l
2.5, it's a little curious that no one ran into this yet.
I suspect that nobody tells make to build clar.o (and nothing else).
Instead, the t/unit-tests/bin/unit-tests target is what is typically
built, which is part of $(CLAR_TEST_PROG) that has clar.suite as one
of its dependencies.
$ make
$ rm -f t/unit-tests/clar.suite t/unit-tests/clar/clar.o
$ make -j1 t/unit-tests/bin/unit-tests
GEN t/unit-tests/clar.suite
CC t/unit-tests/clar/clar.o
LINK t/unit-tests/bin/unit-tests
What is possible to happen from the broken dependencies is when I
did not remove clar.o in the above experiment. We may rebuild
clar.suite and then link clar.o that is outdated without realizing.
quoted hunk
I found it best to declare the dependency directly on clar.o, instead of adjusting the dependencies of CLAR_TEST_OBJS on the line above, since it is really only this clar.c that includes clar.suite Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1810%2Fphil-blain%2Fclar-build-dep-fix-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1810/phil-blain/clar-build-dep-fix-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1810 Makefile | 1 + 1 file changed, 1 insertion(+)diff --git a/Makefile b/Makefile index 2dde1fd2b8b..b615de74811 100644 --- a/Makefile +++ b/Makefile@@ -3911,6 +3911,7 @@ $(UNIT_TEST_DIR)/clar-decls.h: $(patsubst %,$(UNIT_TEST_DIR)/%.c,$(CLAR_TEST_SUI $(UNIT_TEST_DIR)/clar.suite: $(UNIT_TEST_DIR)/clar-decls.h $(QUIET_GEN)awk -f $(UNIT_TEST_DIR)/clar-generate.awk $< >$(UNIT_TEST_DIR)/clar.suite $(CLAR_TEST_OBJS): $(UNIT_TEST_DIR)/clar-decls.h +$(UNIT_TEST_DIR)/clar/clar.o: $(UNIT_TEST_DIR)/clar.suite $(CLAR_TEST_OBJS): EXTRA_CPPFLAGS = -I$(UNIT_TEST_DIR) $(CLAR_TEST_PROG): $(UNIT_TEST_DIR)/clar.suite $(CLAR_TEST_OBJS) $(GITLIBS) GIT-LDFLAGS $(call mkdir_p_parent_template)base-commit: 777489f9e09c8d0dd6b12f9d90de6376330577a2