Thread (20 messages) 20 messages, 4 authors, 2024-10-04

Re: [PATCH 0/5] diff output_prefix cleanups

From: Derrick Stolee <hidden>
Date: 2024-10-04 19:33:22

On 10/3/24 5:05 PM, Jeff King wrote:
 > Here's what I would> put on top (but I would suggest making it a separate 
branch, since yours
is a fairly urgent fix and mine is all cleanup).

   [1/5]: line-log: use diff_line_prefix() instead of custom helper
   [2/5]: diff: drop line_prefix_length field
   [3/5]: diff: return const char from output_prefix callback
   [4/5]: diff: return line_prefix directly when possible
   [5/5]: diff: store graph prefix buf in git_graph struct
I've reviewed these patches and they look good to me. Thanks for
taking the time to split them up carefully to help review go so
smoothly.
  7 files changed, 28 insertions(+), 43 deletions(-)
Excellent to see the line reduction, too.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help