Re: [PATCH v2 6/6] test-tool: add helper for name-hash values
From: Derrick Stolee <hidden>
Date: 2024-09-25 13:35:29
On 9/24/24 3:02 AM, Patrick Steinhardt wrote:
quoted hunk ↗ jump to hunk
This patch breaks t5310 with the leak sanitizer enabled due to the leaking `struct strbuf line`. It needs the following diff on top:diff --git a/t/helper/test-name-hash.c b/t/helper/test-name-hash.c index 15fb8f853c..e4ecd159b7 100644 --- a/t/helper/test-name-hash.c +++ b/t/helper/test-name-hash.c@@ -19,5 +19,6 @@ int cmd__name_hash(int argc UNUSED, const char **argv UNUSED) printf("%10"PRIu32"\t%10"PRIu32"\t%s\n", name_hash, full_hash, line.buf); } + strbuf_release(&line); return 0; }
Thanks! I'll make sure this gets in the next version.
I also plan to eventually have a deeper look at your patch series, but didn't yet find the time to do so until now :(
Thanks for taking the time, when you have it. -Stolee