Thread (1 message) 1 message, 1 author, 2024-09-13

Re: [PATCH 2/4] remote: print an error if refspec cannot be removed

From: Junio C Hamano <hidden>
Date: 2024-09-13 17:38:32

phillip.wood123@gmail.com writes:
On 11/09/2024 21:52, Junio C Hamano wrote:
quoted
"Phillip Wood via GitGitGadget" [off-list ref] writes:
quoted
  	if (!add_mode && remove_all_fetch_refspecs(key.buf)) {
+		error(_("could not remove existing fetch refspec"));
  		strbuf_release(&key);
  		return 1;
  	}
It is a minor point, but would it help to say what we tried to
remove (e.g. "from remote X") or is it too obvious to the end user
in the context they get this error?
The user has to give the remote name on the command line so I think it
should be obvious to the user.
That makes sense.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help