Thread (1 message) 1 message, 1 author, 2024-09-09

Re: [PATCH 1/2] diff: report copies and renames as changes in run_diff_cmd()

From: Junio C Hamano <hidden>
Date: 2024-09-09 16:59:10

Phillip Wood [off-list ref] writes:
quoted
which is inconsistent with the quicker one.  Fix it.  Even if we ignore
the file contents (because it's empty or contains only ignored lines),
there's still the meta data change of adding or changing a filename, so
we need to report it in the exit code.
d7b97b7185 (diff: let external diffs report that changes are
uninteresting, 2024-06-09) set diff_from_contents if external diff
programs are allowed.  This is the default e.g. for git diff, and so
that change exposed the inconsistency much more widely.
Thanks for fixing this - both patches looks good to me.
Yup, thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help