Re: [PATCH 0/5] pack-objects: brown-paper-bag fixes for multi-pack reuse

Jeff King [off-list ref] writes:

On Wed, Sep 04, 2024 at 11:56:27AM -0700, Junio C Hamano wrote:

quoted

Taylor Blau [off-list ref] writes:

quoted

This series fixes a couple of issues (some cosmetic, others less so) in
multi-pack reuse noticed when rolling this out over a few real-world,
internal repositories on GitHub's servers.

I cannot claim I got all the detail that went into steps 2 & 3
right, but I was irritated enough that the topic was left in the
"Needs review" state, so I gave a look at the tail end of the
series, and they were pleasant read.

Sorry, I'm probably the most qualified reviewer here. I read through
the early patches, and I think the fix is correct, along with the
preparation in patch 2.

With the partial disclaimer that I helped with the early debugging, and
my blind flailing at suggestions accidentally led Taylor to the right
answer. I don't think that biases my perspective, but maybe. ;)

Thanks.