Thread (1 message) 1 message, 1 author, 2024-08-22

Re: [PATCH v2 00/20] Memory leak fixes (pt.5)

From: Junio C Hamano <hidden>
Date: 2024-08-22 19:01:07

Patrick Steinhardt [off-list ref] writes:
this is version 2 of this patch series that fixes another set of memory
leaks.

Changes compared to v1:

  - Remove spaces between cast and variable.

  - Clarify why we move the `ctx.entries_nr` block.

  - Adapt sideband colors to use `git_config_get_string_tmp()` such that
    we do not have to allocate the strings in the first place.

  - Fix more memory leaks for config values in the remote state.

  - Refactor `unbundle()` to not free extra args passed by the caller
    anymore. Instead, this is now always done by the caler.
All these changes look sensible to me.

Let me wait for a few days for others' comments, and then mark the
topic for 'next'.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help