Thread (7 messages) 7 messages, 2 authors, 2024-08-17

Re: [PATCH 2/5] pack-bitmap: load writer config from repository parameter

From: Eric Sunshine <hidden>
Date: 2024-08-17 07:33:18

On Sat, Aug 17, 2024 at 3:27 AM Jeff King [off-list ref] wrote:
In bitmap_writer_init(), we take a repository parameter but ever look at
s/ever/never/
it. Most of the initialization here is independent of the repository,
but we do load some config. So let's pass the repo we get down to
load_pseudo_merges_from_config(), which in turn can use repo_config(),
rather than depending on the_repository via git_config().

The outcome is the same, since all callers pass in the_repository
anyway. But it takes us a step closer to getting rid of the global, and
as a bonus it silences an unused parameter warning.

Signed-off-by: Jeff King <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help