On Fri, Aug 16, 2024 at 7:42 PM Jacob Keller [off-list ref] wrote:

On 8/16/2024 4:22 PM, Eric Sunshine wrote:

quoted

What is not explained by the commit message is why we need this new
option as opposed to merely making git-check-mailmap accept such
addresses by default. Are there difficulties or downsides to making
this the default behavior? Do other things break if this new behavior
becomes the default as opposed to being an explicit opt-in?

Mostly I did it this way out of conservative caution to avoid breaking
existing users. It could be that nothing breaks and loosening the
restriction on what we pass it would be sufficient.

I figured that was probably the reason for making this an opt-in.

I think my somewhat negative reaction to this new option -- and the
reason I asked the above question -- is that it feels very
special-case, thus it lacks generality (or at least the way the commit
message sells it, it makes it difficult to see it as anything other
than a bandaid added just to support mailmap in git-send-email).