Re: [PATCH v6 0/8] [Newcomer] t7004: modernize the style
From: Eric Sunshine <hidden>
Date: 2024-08-13 19:58:02
On Thu, Aug 8, 2024 at 12:34 PM AbdAlRahman Gad [off-list ref] wrote:
- Remove whitespace after the redirect operators. - Move number of expect files prepared outside of test_expect_success to be inside the tests that use it. [...] There are still tests that could lose exit status to pipe. This needs to be modernized too, I will fix them in another patch series.
Thanks. This sort of information -- explaining the aim of the series and explaining what will be done later -- is appreciated by reviewers. There are a few additional pieces of information you can include in the cover letter to make life even simpler for reviewers: * provide a link to the previous version of the series * explain what differs in this version as compared with the previous version * include a range-diff showing the actual changes between this version and the previous version (see `git format-patch --range-diff=` There are many good examples on the mailing which illustrate the above points; here is one such instance: https://lore.kernel.org/git/20240726081522.28015-1-ericsunshine@charter.net/ (local)