Re: [PATCH 06/10] reftable/generic: move generic iterator code into iterator interface
From: karthik nayak <hidden>
Date: 2024-08-13 10:04:32
Attachments
- signature.asc [application/pgp-signature] 690 bytes
From: karthik nayak <hidden>
Date: 2024-08-13 10:04:32
Patrick Steinhardt [off-list ref] writes: [snip]
+
+void reftable_iterator_destroy(struct reftable_iterator *it)
+{
+ if (!it->ops) {
+ return;
+ }I know this commit is to move, but I couldn't help noticing that we should remove the curly braces here. Seems like the CI caught it too [1].
+ it->ops->close(it->iter_arg); + it->ops = NULL; + FREE_AND_NULL(it->iter_arg); +} +
[snip] [1]: https://gitlab.com/gitlab-org/git/-/jobs/7563308943