Re: [PATCH v4] http: do not ignore proxy path

Jeff King [off-list ref] writes:

On Thu, Aug 01, 2024 at 05:22:56AM +0000, Ryan Hendrickson via GitGitGadget wrote:

quoted

From: Ryan Hendrickson <redacted>

The documentation for `http.proxy` describes that option, and the
environment variables it overrides, as supporting "the syntax understood
by curl". curl allows SOCKS proxies to use a path to a Unix domain
socket, like `socks5h://localhost/path/to/socket.sock`. Git should
therefore include, if present, the path part of the proxy URL in what it
passes to libcurl.

Co-authored-by: Jeff King [off-list ref]
Signed-off-by: Ryan Hendrickson <redacted>

Thanks for crediting me. I'll add my:

 Signed-off-by: Jeff King [off-list ref]

to be explicit that the proxy script is under the DCO.

OK, I'll amend it while queuing this v4.

Thanks.

quoted

+# The %30 tests that the correct amount of percent-encoding is applied to the
+# proxy string passed to curl.
+test_lazy_prereq SOCKS_PROXY 'test_have_prereq PERL && start_socks "$TRASH_DIRECTORY/%30.sock"'

OK, I see you figured out that the lazy prereq requires giving the full
path to the socket. :) I had forgotten that we also run the prereq in a
subshell to avoid side effects, but you caught that, as well.

;-)

All of this to me is good evidence that the non-lazy version you had
originally is a better approach. But I don't think it's worth spending
time fighting over, so I'm OK either way.

I'd be OK either way, too.

Thanks, both.