Re: [PATCH v2 3/3] ref-filter: populate symref from iterator
From: Junio C Hamano <hidden>
Date: 2024-08-01 16:43:37
"John Cai via GitGitGadget" [off-list ref] writes:
quoted hunk
@@ -2852,6 +2852,8 @@ static struct ref_array_item *apply_ref_filter(const char *refname, const struct ref->commit = commit; ref->flag = flag; ref->kind = kind; + if (flag & REF_ISSYMREF) + ref->symref = xstrdup_or_null(referent);
The same reaction as [1/3]. Doesn't the null-ness of referent convey the same information as the ISSYMREF bit in flag? IOW, can't we do this assignment unconditionally?