Thread (2 messages) 2 messages, 2 authors, 2024-07-16
DORMANTno replies

[PATCH] t-strvec: fix type mismatch in check_strvec

From: René Scharfe <hidden>
Date: 2024-07-16 16:14:54
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Cast i from size_t to uintmax_t to match the format string.

Reported-by: Jeff King <redacted>
Signed-off-by: René Scharfe <redacted>
---
Oops, sorry about that. :-(

PRIuMAX is "lu" on my system, so the compiler didn't flag the mistake.

 t/unit-tests/t-strvec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/unit-tests/t-strvec.c b/t/unit-tests/t-strvec.c
index fdb28ba220..fa1a041469 100644
--- a/t/unit-tests/t-strvec.c
+++ b/t/unit-tests/t-strvec.c
@@ -11,7 +11,8 @@
 		    check_uint((vec)->nr, <=, (vec)->alloc)) { \
 			for (size_t i = 0; i < ARRAY_SIZE(expect); i++) { \
 				if (!check_str((vec)->v[i], expect[i])) { \
-					test_msg("      i: %"PRIuMAX, i); \
+					test_msg("      i: %"PRIuMAX, \
+						 (uintmax_t)i); \
 					break; \
 				} \
 			} \
--
2.45.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help