Thread (1 message) 1 message, 1 author, 2024-07-15

Re: [PATCH v2 2/1] t-strvec: improve check_strvec() output

From: Junio C Hamano <hidden>
Date: 2024-07-15 14:44:07

René Scharfe [off-list ref] writes:
The macro check_strvec calls the function check_strvec_loc(), which
performs the actual checks.  They report the line number inside that
function on error, which is not very helpful.  Before the previous
patch half of them triggered an assertion that reported the caller's
line number using a custom message, which was more useful, but a bit
awkward.
...
We can let check_strvec add the terminating NULL for us and remove it
from callers, making it impossible to forget.  Leave that conversion for
a future patch, though, since this reimplementation is already intrusive
enough.

Reported-by: Jeff King <redacted>
Signed-off-by: René Scharfe <redacted>
---
For next, on top of c6f35e529e t-strvec: use test_msg().
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help