Thread (238 messages) 238 messages, 6 authors, 2024-10-06

Re: [GSoC][PATCH v7 1/9] fsck: rename "skiplist" to "oid_skiplist"

From: Justin Tobler <hidden>
Date: 2024-07-05 22:07:56

On 24/07/03 09:56PM, shejialuo wrote:
Because we introduce ref consistency check. The original "skiplist" is a
common option which is set up during handling user configs. To avoid
causing ambiguity, rename "skiplist" to "oid_skiplist".
I think the commit message could be expanded on to provide additional
context and reasoning for the change. From reading this alone, it sounds
like we have already introduced the ref consistency check and are now
looking to rename a variable. When really this is a preparatory change.
Without reading ahead, I'm also left wondering why this name change
reduces ambiguity.

-Justin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help