Re: [PATCH 0/5] Unify trailer formatting functions
From: Johannes Schindelin <hidden>
Date: 2024-07-02 09:37:34
Hi, On Fri, 15 Mar 2024, Linus Arver wrote:
Junio C Hamano [off-list ref] writes:quoted
Not about the series, but about the way it was sent. The messages in this series have exactly the same kind of breakages in the recipient names/addresses we recently saw: https://lore.kernel.org/git/xmqqh6hkxox6.fsf@gitster.g/ (local) Human-readable names with a SP inside [square bracket] pair appended, and one of the addresses had that square bracket applied inside <angle bracket> pair and breaking MTAs (I manually fixed khaugsbakk's address before sending this response, so replying to this messages should be OK).UGH, I'm so sorry about that.quoted
What are you and Aryan's pull.1675.v3 did differently from other series sent via GGG to trigger this, I have to wonder?I realize now that it's because I copy/pasted the "Cc: ..." lines in the PR description from https://github.com/gitgitgadget/git/pull/1632#issue-2068188239, such that when I pasted those in for the PR description for this series at https://github.com/gitgitgadget/git/pull/1694#issue-2187804953, it carried over the email addresses as Markdown-formatted hyperlinks. Currently it reads Cc: Christian Couder [chriscool@tuxfamily.org](mailto:chriscool@tuxfamily.org) Cc: Junio C Hamano [gitster@pobox.com](mailto:gitster@pobox.com) Cc: Emily Shaffer [nasamuffin@google.com](mailto:nasamuffin@google.com) cc: Josh Steadmon [steadmon@google.com](mailto:steadmon@google.com) cc: Randall S. Becker [rsbecker@nexbridge.com](mailto:rsbecker@nexbridge.com) cc: Christian Couder [christian.couder@gmail.com](mailto:christian.couder@gmail.com) cc: "Kristoffer Haugsbakk" [code@khaugsbakk.name](mailto:code@khaugsbakk.name) cc: "Kristoffer Haugsbakk" [off-list ref] when I click on "edit", where the last line must be from your manual fix which GGG picked up. I've cleaned up the PR description manually now, and for this message I'm also attempting to clean up those square brackets.
I would love to let myself be nerdsniped into working on this, alas, I cannot afford that before I learn the trick to stretch time. So I did the next-best thing and jotted down pointers for any volunteer who wants to work on this: https://github.com/gitgitgadget/gitgitgadget/issues/1645#issuecomment-2202545542 Ciao, Johannes