Re: [PATCH v2 1/5] sparse-checkout: refactor skip worktree retry logic
From: Derrick Stolee <hidden>
Date: 2024-06-28 01:56:59
On 6/27/24 8:31 PM, Elijah Newren wrote:
On Wed, Jun 26, 2024 at 7:29 AM Derrick Stolee via GitGitGadget [off-list ref] wrote:quoted
From: Derrick Stolee <redacted>[...]quoted
If users are having trouble with the performance of this operation and don't care about paths outside of the sparse-checkout, they can disable them using the sparse.expectFilesOutsideOfPatterns config option introduced in ecc7c8841d (repo_read_index: add config to expect files outside sparse patterns, 2022-02-25).So, I had some heartburn with this paragraph when reading v1, but decided to focus on other stuff. But it still really bugs me while reading v2. So...
Thanks for bringing this up with the details I've omitted from the context of my response.
Could we omit this paragraph, or if you want to keep it, reword it in some way that doesn't make it look like some tradeoff that isn't that big of a deal for non-specialized-vfs users?
Makes sense to delete the paragraph. I could ship a v3, or is this a commit-message surgery you'd be willing to do on my behalf, Junio? Thanks, -Stolee