Re: [PATCH] archive: document that --add-virtual-file takes full path
From: René Scharfe <hidden>
Date: 2024-06-26 19:06:09
Am 26.06.24 um 00:43 schrieb Junio C Hamano:
Junio C Hamano [off-list ref] writes:quoted
quoted
It has been a few weeks since this discussion stalled. Let me make an executive decision on the direction here---let's keep the behaviour and align the documentation so that we won't break existing users. Thanks.So here is to re-ignite the discussion. ----- >8 ----- Subject: [PATCH] archive: document that --add-virtual-file takes full pathAnd it seems that nobody is interested in the topic all that much anymore?
I'm low-key pleased to see a documentation bug being stomped. Perhaps this saps the energy out of efforts to make --add-virtual-file respect --prefix, but we'd probably need a new option name for that anyway to keep backward compatibility (--add-prefix-file?), so the patch adds no technical obstacle for that at least.
I've read the updated text once again, and didn't see anything glaringly wrong, so I'll mark it for 'next'.
The patch looks good to me. I like the new paragraph about --prefix not being respected, in particular because I wouldn't thought of adding it, but it does look helpful. Perhaps add a Reported-by: line for Tom that's findable with trailer tooling, though? René