Thread (7 messages) 7 messages, 3 authors, 2024-06-25

Re: [PATCH] describe: refresh the index when 'broken' flag is used

From: Abhijeet Sonar <hidden>
Date: 2024-06-24 12:20:53

On 24/06/24 16:50, Phillip Wood wrote:
This is a good description of the problem the patch fixes.
Thanks!
As we're dealing with a repository that might be broken I suspect we'd 
be better to run "git update-index --unmerged -q --refresh" as a 
subprocess in the same way that we run "git diff-index" so that "git 
describe --broken" does not die if the index cannot be refreshed.
I see, that makes sense.  I will change it to launch `update-index` in a 
sub-process
instead.
quoted
Also apart from that, we should add a test to capture the changes.
That would be nice
Got it, I will add some tests as well.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help