Re: [PATCH v3] pager: die when paging to non-existing command
From: Johannes Sixt <hidden>
Date: 2024-06-22 07:09:00
From: Johannes Sixt <hidden>
Date: 2024-06-22 07:09:00
Am 22.06.24 um 01:31 schrieb Rubén Justo:
Let's make the error clear by aborting the process and return an error
so that the user can easily correct their mistake.
This will be the result of the change:
$ GIT_PAGER=non-existent t/test-terminal.perl git log | wc -c
error: cannot run non-existent: No such file or directory
fatal: unable to start the pager: 'non-existent'
0Not a big deal, but the error message cited here does not match the actual new text:
if (start_command(&pager_process))
- return;
+ die("unable to execute pager '%s'", pager);-- Hannes