Thread (7 messages) 7 messages, 3 authors, 2024-06-23

Re: [PATCH v3] pager: die when paging to non-existing command

From: Johannes Sixt <hidden>
Date: 2024-06-22 07:09:00

Am 22.06.24 um 01:31 schrieb Rubén Justo:
Let's make the error clear by aborting the process and return an error
so that the user can easily correct their mistake.

This will be the result of the change:

    $ GIT_PAGER=non-existent t/test-terminal.perl git log | wc -c
    error: cannot run non-existent: No such file or directory
    fatal: unable to start the pager: 'non-existent'
    0
Not a big deal, but the error message cited here does not match the
actual new text:
 	if (start_command(&pager_process))
-		return;
+		die("unable to execute pager '%s'", pager);
-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help