Thread (1 message) 1 message, 1 author, 2024-06-21

Re: [PATCH] pager: die when paging to non-existing command

From: Junio C Hamano <hidden>
Date: 2024-06-21 23:21:46

Phillip Wood [off-list ref] writes:
On 20/06/2024 20:04, Junio C Hamano wrote:
quoted
Rubén Justo [off-list ref] writes:
quoted
--- a/pager.c
+++ b/pager.c
@@ -137,7 +137,7 @@ void setup_pager(void)
  	pager_process.in = -1;
  	strvec_push(&pager_process.env, "GIT_PAGER_IN_USE");
  	if (start_command(&pager_process))
-		return;
+		die("unable to start the pager: '%s'", pager);
If this error string is not used elsewhere, it probably is a good
idea to "revert" to the original error message lost by ea27a18c,
which was:
		die("unable to execute pager '%s'", pager);
Either way I think we want to mark the message for translation
Given that none of the die() message in this file is marked for
localization, I would strongly prefer to see this patch not to do
so.  Possibly as part of a larger clean-up patch series, but not as
"while at it" item for this fix.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help