Re: [PATCH] pager: die when paging to non-existing command

Rubén Justo [off-list ref] writes:

On Thu, Jun 20, 2024 at 12:04:03PM -0700, Junio C Hamano wrote:

quoted

quoted

+		die("unable to start the pager: '%s'", pager);

If this error string is not used elsewhere, it probably is a good
idea to "revert" to the original error message lost by ea27a18c,
which was:

		die("unable to execute pager '%s'", pager);

Makes sense.  Let me know if you need me to reroll.

quoted

Just in case there is a reason why we should instead silently return
on MinGW, I'll Cc the author of bfdd9ffd, though.

Yup.  I did notice the MINGW conditions in t7006 but, to be honest, I
hadn't thought about this.  Thank you for considering it and seeking
confirmation.

After these questions are answered satisfactory, can you send an
updated version to conclude the topic?

Thanks.